netdev - Re: [PATCH v2] phy: remove documentation of removed members of phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160310142156.GE20539@lunn.ch>
Date:	Thu, 10 Mar 2016 15:21:56 +0100
From:	Andrew Lunn <andrew@...n.ch>
To:	LABBE Corentin <clabbe.montjoie@...il.com>
Cc:	f.fainelli@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] phy: remove documentation of removed members of
 phy_device structure

On Thu, Mar 10, 2016 at 01:58:58PM +0100, LABBE Corentin wrote:
> Commit e5a03bfd873c ("phy: Add an mdio_device structure") removed addr,
> bus and dev member of the phy_device structure.
> This patch remove the documentation about those members.
> 
> Signed-off-by: LABBE Corentin <clabbe.montjoie@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

Hi Corentin

Thanks for updating the patch with the extra removals.

       Andrew

> ---
>  include/linux/phy.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> Changes since v1
> - remove also documentation for dev and bus
> 
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index d6f3641..2abd791 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -327,8 +327,6 @@ struct phy_c45_device_ids {
>  /* phy_device: An instance of a PHY
>   *
>   * drv: Pointer to the driver for this PHY instance
> - * bus: Pointer to the bus this PHY is on
> - * dev: driver model device structure for this PHY
>   * phy_id: UID for this device found during discovery
>   * c45_ids: 802.3-c45 Device Identifers if is_c45.
>   * is_c45:  Set to true if this phy uses clause 45 addressing.
> @@ -338,7 +336,6 @@ struct phy_c45_device_ids {
>   * suspended: Set to true if this phy has been suspended successfully.
>   * state: state of the PHY for management purposes
>   * dev_flags: Device-specific flags used by the PHY driver.
> - * addr: Bus address of PHY
>   * link_timeout: The number of timer firings to wait before the
>   * giving up on the current attempt at acquiring a link
>   * irq: IRQ number of the PHY's interrupt (-1 if none)
> -- 
> 2.4.10
>