netdev - Re: [PATCH] kcm: fix variable type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160311.114442.1933815095495449507.davem@davemloft.net>
Date:	Fri, 11 Mar 2016 11:44:42 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	a.hajda@...sung.com
Cc:	tom@...bertland.com, b.zolnierkie@...sung.com,
	m.szyprowski@...sung.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kcm: fix variable type

From: Andrzej Hajda <a.hajda@...sung.com>
Date: Fri, 11 Mar 2016 07:51:15 +0100

> Function skb_splice_bits can return negative values, its result should
> be assigned to signed variable to allow correct error checking.
> 
> The problem has been detected using patch
> scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci.
> 
> Signed-off-by: Andrzej Hajda <a.hajda@...sung.com>

Since skb_splice_bits() returns an 'int', that would be a more appropriate
type to use here.

Thank you.