netdev - Re: [PATCH net-next 2/4] ldmvsw: Make sunvnet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160311.142733.1237549201193012342.davem@davemloft.net>
Date:	Fri, 11 Mar 2016 14:27:33 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	Aaron.Young@...cle.com
Cc:	netdev@...r.kernel.org, sowmini.varadhan@...cle.com,
	alexandre.chartre@...cle.com, rashmi.narasimhan@...cle.com
Subject: Re: [PATCH net-next 2/4] ldmvsw: Make sunvnet_common compatible
 with ldmvsw

From: Aaron Young <Aaron.Young@...cle.com>
Date: Tue,  8 Mar 2016 07:02:34 -0800

> @@ -719,12 +720,13 @@ static void maybe_tx_wakeup(struct vnet_port *port)
>  	__netif_tx_unlock(txq);
>  }
>  
> -static inline bool port_is_up(struct vnet_port *vnet)
> +inline bool port_is_up_common(struct vnet_port *vnet)

All of these things in foo.c files shouldn't have an inline attribute.

>  {
>  	struct vio_driver_state *vio = &vnet->vio;
>  
>  	return !!(vio->hs_state & VIO_HS_COMPLETE);
>  }
> +EXPORT_SYMBOL(port_is_up_common);

Especially if they are also exported.

Need to use EXPORT_SYMBOL_GPL() here as well, but I seriously think you need to rename
this function in order to not pollute the global namespace of exported kernel symbols.
You need to add a suitable prefix such as sunvnet_*() or whatever.