netdev - [PATCH V2 net 4/4] net: hns: remove useless head=ring->next_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1457691622-124657-5-git-send-email-lisheng011@huawei.com>
Date:	Fri, 11 Mar 2016 18:20:22 +0800
From:	Lisheng <lisheng011@...wei.com>
To:	<davem@...emloft.net>
CC:	<yisen.zhuang@...wei.com>, <yankejian@...wei.com>,
	<xieqianqian@...wei.com>, <huangdaode@...ilicon.com>,
	<salil.mehta@...wei.com>, <andriy.shevchenko@...ux.intel.com>,
	<netdev@...r.kernel.org>, <haifeng.wei@...wei.com>,
	<charles.chenxin@...wei.com>, <linuxarm@...wei.com>
Subject: [PATCH V2 net 4/4] net: hns: remove useless head=ring->next_to_clean

From: Qianqian Xie <xieqianqian@...wei.com>

The variable head in hns_nic_tx_fini_pro has read a value,
but the value is not used. The patch will solve it.
The bug-fixed comment is for the function pointer
ring_data->fini_process,that is called in function
hns_nic_common_poll.The comment should not be there, so remove it.

Signed-off-by: Qianqian Xie <xieqianqian@...wei.com>
---
change log:
PATCH v2:
 - This patchset fixes the comments provided by Andy Shevchenko <Andy Shevchenko>

PATCH v1:
 - first submit
---
 drivers/net/ethernet/hisilicon/hns/hns_enet.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
index 3f77ff7..5456531 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
@@ -901,10 +901,7 @@ static int hns_nic_tx_poll_one(struct hns_nic_ring_data *ring_data,
 static void hns_nic_tx_fini_pro(struct hns_nic_ring_data *ring_data)
 {
 	struct hnae_ring *ring = ring_data->ring;
-	int head = ring->next_to_clean;
-
-	/* for hardware bug fixed */
-	head = readl_relaxed(ring->io_base + RCB_REG_HEAD);
+	int head = readl_relaxed(ring->io_base + RCB_REG_HEAD);
 
 	if (head != ring->next_to_clean) {
 		ring_data->ring->q->handle->dev->ops->toggle_ring_irq(
-- 
1.9.1