netdev - Re: [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Mar 2016 16:29:29 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Daode Huang <huangdaode@...ilicon.com>, davem@...emloft.net
Cc:	liguozhu@...ilicon.com, Yisen.Zhuang@...wei.com,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	netdev@...r.kernel.org, linuxarm@...wei.com,
	salil.mehta@...wei.com, kenneth-lee-2012@...mail.com,
	xuwei5@...ilicon.com, lisheng011@...wei.com, yankejian@...wei.com
Subject: Re: [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt

Hello.

On 3/11/2016 4:53 AM, Daode Huang wrote:

>>> In V2 chip, when sending mamagement packets, the driver should
>>> config the port id to BD descs.
>>>
>>> Signed-off-by: Daode Huang <huangdaode@...ilicon.com>
>>> Signed-off-by: Lisheng <lisheng011@...wei.com>
>>> ---
>>>   drivers/net/ethernet/hisilicon/hns/hnae.h         | 3 +++
>>>   drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 1 +
>>>   drivers/net/ethernet/hisilicon/hns/hns_enet.c     | 4 ++++
>>>   3 files changed, 8 insertions(+)
>>>
>>> diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.h
>>> b/drivers/net/ethernet/hisilicon/hns/hnae.h
>>> index 1cbcb9f..11a3f97 100644
>>> --- a/drivers/net/ethernet/hisilicon/hns/hnae.h
>>> +++ b/drivers/net/ethernet/hisilicon/hns/hnae.h
>> [...]
>>> @@ -516,6 +518,7 @@ struct hnae_handle {
>>>       int q_num;
>>>       int vf_id;
>>>       u32 eport_id;
>>> +    u32 dport_id;    /*v2 tx bd should fill the dport_id*/
>>
>>    Please add spaces after /* and before */ (like it's done in other places
>> in this driver).
>>
>
> Hi MBR, Sergei,

    Just in case: MBR stands for "my best regards", Sergei is my name. :-)

> Daode.

MBR, Sergei