netdev - Re: [PATCH v2 3/9] net: arc_emac: support the phy reset for emac driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 13 Mar 2016 17:38:55 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Caesar Wang <wxt@...k-chips.com>
Cc:	kbuild-all@...org, Heiko Stuebner <heiko@...ech.de>,
	"David S. Miller" <davem@...emloft.net>,
	Rob Herring <robh+dt@...nel.org>,
	linux-rockchip@...ts.infradead.org, keescook@...gle.com,
	leozwang@...gle.com, sergei.shtylyov@...entembedded.com,
	netdev@...r.kernel.org, Caesar Wang <wxt@...k-chips.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/9] net: arc_emac: support the phy reset for emac
 driver

Hi Caesar,

[auto build test ERROR on next-20160311]
[also build test ERROR on v4.5-rc7]
[cannot apply to rockchip/for-next net-next/master v4.5-rc7 v4.5-rc6 v4.5-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Caesar-Wang/arc_emac-fixes-the-emac-issues-and-cleanup-emac-drivers/20160313-171602
config: s390-allmodconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=s390 

All errors (new ones prefixed by >>):

   drivers/net/ethernet/arc/emac_mdio.c: In function 'arc_mdio_reset':
>> drivers/net/ethernet/arc/emac_mdio.c:112:3: error: implicit declaration of function 'gpiod_set_value_cansleep' [-Werror=implicit-function-declaration]
      gpiod_set_value_cansleep(data->reset_gpio, 1);
      ^
   drivers/net/ethernet/arc/emac_mdio.c: In function 'arc_mdio_probe':
>> drivers/net/ethernet/arc/emac_mdio.c:149:2: error: implicit declaration of function 'devm_gpiod_get_optional' [-Werror=implicit-function-declaration]
     data->reset_gpio = devm_gpiod_get_optional(priv->dev, "reset",
     ^
>> drivers/net/ethernet/arc/emac_mdio.c:150:10: error: 'GPIOD_OUT_LOW' undeclared (first use in this function)
             GPIOD_OUT_LOW);
             ^
   drivers/net/ethernet/arc/emac_mdio.c:150:10: note: each undeclared identifier is reported only once for each function it appears in
   cc1: some warnings being treated as errors

vim +/gpiod_set_value_cansleep +112 drivers/net/ethernet/arc/emac_mdio.c

   106	int arc_mdio_reset(struct mii_bus *bus)
   107	{
   108		struct arc_emac_priv *priv = bus->priv;
   109		struct arc_emac_mdio_bus_data *data = &priv->bus_data;
   110	
   111		if (data->reset_gpio) {
 > 112			gpiod_set_value_cansleep(data->reset_gpio, 1);
   113			msleep(data->msec);
   114			gpiod_set_value_cansleep(data->reset_gpio, 0);
   115		}
   116	
   117		return 0;
   118	}
   119	
   120	/**
   121	 * arc_mdio_probe - MDIO probe function.
   122	 * @priv:	Pointer to ARC EMAC private data structure.
   123	 *
   124	 * returns:	0 on success, -ENOMEM when mdiobus_alloc
   125	 * (to allocate memory for MII bus structure) fails.
   126	 *
   127	 * Sets up and registers the MDIO interface.
   128	 */
   129	int arc_mdio_probe(struct arc_emac_priv *priv)
   130	{
   131		struct arc_emac_mdio_bus_data *data = &priv->bus_data;
   132		struct device_node *np = priv->dev->of_node;
   133		struct mii_bus *bus;
   134		int error;
   135	
   136		bus = mdiobus_alloc();
   137		if (!bus)
   138			return -ENOMEM;
   139	
   140		priv->bus = bus;
   141		bus->priv = priv;
   142		bus->parent = priv->dev;
   143		bus->name = "Synopsys MII Bus",
   144		bus->read = &arc_mdio_read;
   145		bus->write = &arc_mdio_write;
   146		bus->reset = &arc_mdio_reset;
   147	
   148		/* optional reset-related properties */
 > 149		data->reset_gpio = devm_gpiod_get_optional(priv->dev, "reset",
 > 150							   GPIOD_OUT_LOW);
   151		if (IS_ERR(data->reset_gpio)) {
   152			error = PTR_ERR(data->reset_gpio);
   153			dev_err(priv->dev, "Failed to request gpio: %d\n", error);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (40567 bytes)