netdev - Re: [PATCH v7 net-next] ravb: Add dma queue interrupt support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56E72394.5030905@cogentembedded.com>
Date:	Mon, 14 Mar 2016 23:48:20 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Yoshihiro Kaneko <ykaneko0929@...il.com>, netdev@...r.kernel.org
Cc:	"David S. Miller" <davem@...emloft.net>,
	Simon Horman <horms@...ge.net.au>,
	Magnus Damm <magnus.damm@...il.com>,
	linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v7 net-next] ravb: Add dma queue interrupt support

Hello.

On 03/13/2016 09:11 PM, Yoshihiro Kaneko wrote:

> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@...esas.com>
>
> This patch supports the following interrupts.
>
> - One interrupt for multiple (timestamp, error, gPTP)
> - One interrupt for emac
> - Four interrupts for dma queue (best effort rx/tx, network control rx/tx)
>
> This patch improve efficiency of the interrupt handler by adding the
> interrupt handler corresponding to each interrupt source described
> above. Additionally, it reduces the number of times of the access to
> EthernetAVB IF.
> Also this patch prevent this driver depends on the whim of a boot loader.
>
> [ykaneko0929@...il.com: define bit names of registers]
> [ykaneko0929@...il.com: add comment for gen3 only registers]
> [ykaneko0929@...il.com: fix coding style]
> [ykaneko0929@...il.com: update changelog]
> [ykaneko0929@...il.com: gen3: fix initialization of interrupts]
> [ykaneko0929@...il.com: gen3: fix clearing interrupts]
> [ykaneko0929@...il.com: gen3: add helper function for request_irq()]
> [ykaneko0929@...il.com: gen3: remove IRQF_SHARED flag for request_irq()]
> [ykaneko0929@...il.com: revert ravb_close() and ravb_ptp_stop()]
> [ykaneko0929@...il.com: avoid calling free_irq() to non-hooked interrupts]
> [ykaneko0929@...il.com: make NC/BE interrupt handler a function]
> [ykaneko0929@...il.com: make timestamp interrupt handler a function]
> [ykaneko0929@...il.com: timestamp interrupt is handled in multiple
>   interrupt handler instead of dma queue interrupt handler]
> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@...esas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@...il.com>
[...]
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index 8f2c4fb..8fa8ffe 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
[...]
> @@ -757,14 +806,73 @@ static irqreturn_t ravb_interrupt(int irq, void *dev_id)
>   		result = IRQ_HANDLED;
>   	}
>
> -	if (iss & ISS_CGIS)
> -		result = ravb_ptp_interrupt(ndev);
> +	/* gPTP interrupt status summary */
> +	if ((iss & ISS_CGIS) && ravb_ptp_interrupt(ndev) == IRQ_HANDLED)
> +		result = IRQ_HANDLED;

    Wait, this seems like a bug in the existing driver! Please do fix it with 
a separate patch against net.git. Sorry about missing (or even adding) it 
while cleaning up the driver before submission...

[...]

    Looks fine otherwise, however the new features and the fixes shouldn't be 
mixed together, so I couldn't ACK yet. I'll go test it on gen2...

MBR, Sergei