netdev - Re: [PATCH next v2 0/7] Introduce l3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160313.235358.1007563444789525672.davem@davemloft.net>
Date:	Sun, 13 Mar 2016 23:53:58 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	maheshb@...gle.com
Cc:	mahesh@...dewar.net, edumazet@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH next v2 0/7] Introduce l3_dev pointer for L3 processing

From: Mahesh Bandewar <maheshb@...gle.com>
Date: Sun, 13 Mar 2016 19:29:58 -0700

> On Sun, Mar 13, 2016 at 6:50 PM, David Miller <davem@...emloft.net> wrote:
>> It doesn't matter whether doing so or not makes sense.
>>
>> You're going to have to find a way to do both, and also I'm concerned
>> about how you're leaking the source namespace's "stuff" into the
>> destination's.  That's very worrisome to me.
>
> If we add a new mode (e.g. L3s) and preserve current mode as is it,
> then that should address your first concern.

Also, I don't want all of this device translation stuff all over the
place.

Furthermore, when you walk across the ns boundary, that old device has
to disappear.  That's why that is the device assigned to skb->dev.

Please stop pretending that this device switching is ok, it's not.