netdev - Re: [PATCHv3 (net.git) 2/2] stmmac: fix MDIO settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Mar 2016 10:14:06 +0100
From:	Gabriel Fernandez <gabriel.fernandez@...aro.org>
To:	Giuseppe Cavallaro <peppe.cavallaro@...com>
Cc:	netdev@...r.kernel.org,
	Andreas Färber <afaerber@...e.de>,
	fschaefer.oss@...glemail.com, Dinh Nguyen <dinh.linux@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Phil Reid <preid@...ctromag.com.au>
Subject: Re: [PATCHv3 (net.git) 2/2] stmmac: fix MDIO settings

Hi Peppe,

Just one remark below

> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> index 6a52fa1..d2322e9 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c

[snip]

> +static bool stmmac_dt_phy(struct plat_stmmacenet_data *plat,
> +                         struct device_node *np, struct device *dev)
> +{
> +       bool ret = true;
> +
> +       /* If phy-handle property is passed from DT, use it as the PHY */
> +       plat->phy_node = of_parse_phandle(np, "phy-handle", 0);
> +       if (plat->phy_node)
> +               dev_dbg(dev, "Found phy-handle subnode\n");
> +
> +       /* If phy-handle is not specified, check if we have a fixed-phy */
> +       if (!plat->phy_node && of_phy_is_fixed_link(np)) {
> +               if ((of_phy_register_fixed_link(np) < 0))
> +                       return -ENODEV;
> +
stmmac_dt_phy() function should return a Boolean


Best Regards.

Gabriel