netdev - Re: [ethtool PATCH v4 11/11] ethtool.c: support absence of v4 sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Mar 2016 16:19:11 -0700
From:	David Decotigny <ddecotig@...il.com>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Jeff Garzik <jgarzik@...ox.com>,
	David Miller <davem@...hat.com>,
	Vidya Sagar Ravipati <vidya@...ulusnetworks.com>,
	Joe Perches <joe@...ches.com>
Subject: Re: [ethtool PATCH v4 11/11] ethtool.c: support absence of v4 sockets

will send a v5 shortly without this patch: question below.

about this patch: this is in prevision of a world where INET can be
compiled out. So it is not something that matters today with current
kernels.

Now, as you mentioned in another patch, the only socket that survives
various reasonable CONFIG_* gymnastics is netlink. So even though
non-IPv4 kernels with IP support is not feasible today, I believe
there is some logic to using netlink sockets for ethtool purposes,
instead of IPv4 or IPv6 sockets. Shall I propose a patch to add
ethtool support on AF_NETLINK sockets, and update the tool to try
AF_INET first for backward compatibility reasons, then fallback to
AF_NETLINK?

On Sun, Mar 13, 2016 at 10:24 AM, Ben Hutchings <ben@...adent.org.uk> wrote:
> On Fri, 2016-03-11 at 09:58 -0800, David Decotigny wrote:
>> From: David Decotigny <decot@...glers.com>
>>
>>
>> Signed-off-by: David Decotigny <decot@...glers.com>
>> ---
>>  ethtool.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/ethtool.c b/ethtool.c
>> index 761252f..f9336e3 100644
>> --- a/ethtool.c
>> +++ b/ethtool.c
>> @@ -4615,6 +4615,9 @@ opt_found:
>>               /* Open control socket. */
>>               ctx.fd = socket(AF_INET, SOCK_DGRAM, 0);
>>               if (ctx.fd < 0) {
>> +                     ctx.fd = socket(AF_UNIX, SOCK_DGRAM, 0);
>> +             }
>
> You still haven't answered whether this is a real problem on Linux.
>
> Ben.
>
>> +             if (ctx.fd < 0) {
>>                       perror("Cannot get control socket");
>>                       return 70;
>>               }
> --
> Ben Hutchings
> If at first you don't succeed, you're doing about average.