netdev - Re: [PATCH] batman-adv: Less function calls in batadv_is_ap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160315001446.GA29332@prodigo>
Date:	Tue, 15 Mar 2016 08:14:46 +0800
From:	Antonio Quartulli <a@...table.cc>
To:	David Miller <davem@...emloft.net>
Cc:	elfring@...rs.sourceforge.net, b.a.t.m.a.n@...ts.open-mesh.org,
	netdev@...r.kernel.org, mareklindner@...mailbox.ch,
	sw@...onwunderlich.de, sven@...fation.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	julia.lawall@...6.fr
Subject: Re: [PATCH] batman-adv: Less function calls in
 batadv_is_ap_isolated() after error detection

On Mon, Mar 14, 2016 at 03:25:02PM -0400, David Miller wrote:
> From: SF Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 11 Mar 2016 13:40:56 +0100
> 
> > From: Markus Elfring <elfring@...rs.sourceforge.net>
> > Date: Fri, 11 Mar 2016 13:10:20 +0100
> > 
> > The variables "tt_local_entry" and "tt_global_entry" were eventually
> > checked again despite of a corresponding null pointer test before.
> > 
> > * Avoid this double check by reordering a function call sequence
> >   and the better selection of jump targets.
> > 
> > * Omit the initialisation for these variables at the beginning then.
> > 
> > Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> 
> I am assuming Antonio will take this in via his tree.
> 

Yeah, it will go through our tree. Still under review right now.

Cheers,

-- 
Antonio Quartulli

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)