netdev - Re: [patch 1/2 net-next] mediatek: checking for IS_ERR() instead of NULL

Open Source and information security mailing list archives

Message-ID: <56E7B973.4050604@openwrt.org>
Date:	Tue, 15 Mar 2016 08:27:47 +0100
From:	John Crispin <blogic@...nwrt.org>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	Felix Fietkau <nbd@...nwrt.org>
Cc:	Matthias Brugger <matthias.bgg@...il.com>, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org, linux-mediatek@...ts.infradead.org
Subject: Re: [patch 1/2 net-next] mediatek: checking for IS_ERR() instead of
 NULL


On 15/03/2016 08:18, Dan Carpenter wrote:
> of_phy_connect() returns NULL on error, it never returns error pointers.
> 
> Fixes: 656e705243fd ('net-next: mediatek: add support for MT7623 ethernet')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
Acked-by: John Crispin <blogic@...nwrt.org>

Thanks !

> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index ba3afa5..9759fe5 100644
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -186,9 +186,9 @@ static int mtk_phy_connect_node(struct mtk_eth *eth, struct mtk_mac *mac,
>  
>  	phydev = of_phy_connect(eth->netdev[mac->id], phy_node,
>  				mtk_phy_link_adjust, 0, phy_mode);
> -	if (IS_ERR(phydev)) {
> +	if (!phydev) {
>  		dev_err(eth->dev, "could not connect to PHY\n");
> -		return PTR_ERR(phydev);
> +		return -ENODEV;
>  	}
>  
>  	dev_info(eth->dev,
> 
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives