netdev - Re: [PATCH] bus: mvebu-mbus: use %pad to print phys_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Mar 2016 03:09:00 -0700
From:	Joe Perches <joe@...ches.com>
To:	Arnd Bergmann <arnd@...db.de>,
	"David S . Miller" <davem@...emloft.net>
Cc:	Marcin Wojtas <mw@...ihalf.com>, Evan Wang <xswang@...vell.com>,
	Gregory CLEMENT <gregory.clement@...e-electrons.com>,
	netdev@...r.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	Nicolas Schichan <nschichan@...ebox.fr>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bus: mvebu-mbus: use %pad to print phys_addr_t

On Tue, 2016-03-15 at 11:03 +0100, Arnd Bergmann wrote:
> A recent change to the mbus driver added a warning printk that
> prints a phys_addr_t using the %x format string, which fails in
> case we build with 64-bit phys_addr_t:

Hey Arnd.

This is a bad patch subject, %pad is for a dma_addr_t.
The patch subject made me assume the patch was incorrect.

> > This uses the special %pa format string instead, so we always
> print the correct type.
[]
> -	pr_err("invalid dram address 0x%x\n", phyaddr);
> +	pr_err("invalid dram address %pa\n", &phyaddr);

The patch is good though.