netdev - Re: [net-next 1/2] bonding: remove duplicate set of flag IFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160316140108.GO572@gospo.home.greyhouse.net>
Date:	Wed, 16 Mar 2016 10:01:09 -0400
From:	Andy Gospodarek <gospo@...ulusnetworks.com>
To:	Zhang Shengju <zhangshengju@...s.chinamobile.com>
Cc:	davem@...emloft.net, j.vosburgh@...il.com, jiri@...nulli.us,
	netdev@...r.kernel.org
Subject: Re: [net-next 1/2] bonding: remove duplicate set of flag
 IFF_MULTICAST

On Wed, Mar 16, 2016 at 09:59:15AM +0000, Zhang Shengju wrote:
> Remove unnecessary set of flag IFF_MULTICAST, since ether_setup
> already does this.
> 
> Signed-off-by: Zhang Shengju <zhangshengju@...s.chinamobile.com>
Signed-off-by: Andy Gospodarek <gospo@...ulusnetworks.com>

> ---
>  drivers/net/bonding/bond_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index b6236ff..270b39c 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -4175,7 +4175,7 @@ void bond_setup(struct net_device *bond_dev)
>  	SET_NETDEV_DEVTYPE(bond_dev, &bond_type);
>  
>  	/* Initialize the device options */
> -	bond_dev->flags |= IFF_MASTER|IFF_MULTICAST;
> +	bond_dev->flags |= IFF_MASTER;
>  	bond_dev->priv_flags |= IFF_BONDING | IFF_UNICAST_FLT | IFF_NO_QUEUE;
>  	bond_dev->priv_flags &= ~(IFF_XMIT_DST_RELEASE | IFF_TX_SKB_SHARING);
>  
> -- 
> 1.8.3.1
> 
> 
>