netdev - Re: [PATCH net-next] ethtool: Set cmd field in ETHTOOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1458171392.31907.39.camel@decadent.org.uk>
Date:	Wed, 16 Mar 2016 23:36:32 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ethtool: Set cmd field in
 ETHTOOL_GLINKSETTINGS response to wrong nwords

On Wed, 2016-03-16 at 19:26 -0400, David Miller wrote:
> From: Ben Hutchings <ben@...adent.org.uk>
> Date: Mon, 14 Mar 2016 01:05:38 +0000
> 
> > When the ETHTOOL_GLINKSETTINGS implementation finds that userland is
> > using the wrong number of words of link mode bitmaps (or is trying to
> > find out the right numbers) it sets the cmd field to 0 in the response
> > structure.
> > 
> > This is inconsistent with the implementation of every other ethtool
> > command, so let's remove that inconsistency before it gets into a
> > stable release.
> > 
> > Fixes: 3f1ac7a700d03 ("net: ethtool: add new ETHTOOL_xLINKSETTINGS API")
> > Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> 
> Applied and queued up for -stable, thanks Ben.

This doesn't need fixing in any stable release.

Ben.

-- 
Ben Hutchings
If you seem to know what you are doing, you'll be given more to do.
Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)