netdev - Re: [PATCH 1/5] net: macb: Fix coding style error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56E9621B.3090204@atmel.com>
Date:	Wed, 16 Mar 2016 14:39:39 +0100
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Moritz Fischer <moritz.fischer@...us.com>
CC:	<michal.simek@...inx.com>, <joe@...ches.com>,
	<davem@...emloft.net>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <moritz.fischer.private@...il.com>
Subject: Re: [PATCH 1/5] net: macb: Fix coding style error message

Le 13/03/2016 20:10, Moritz Fischer a écrit :
> checkpatch.pl gave the following error:
> 
> ERROR: space required before the open parenthesis '('
> +	for(; p < end; p++, offset += 4)
> 
> Signed-off-by: Moritz Fischer <moritz.fischer@...us.com>

Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>


> ---
>  drivers/net/ethernet/cadence/macb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index 50c9410..4370f37 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -496,7 +496,7 @@ static void macb_update_stats(struct macb *bp)
>  
>  	WARN_ON((unsigned long)(end - p - 1) != (MACB_TPF - MACB_PFR) / 4);
>  
> -	for(; p < end; p++, offset += 4)
> +	for (; p < end; p++, offset += 4)
>  		*p += bp->macb_reg_readl(bp, offset);
>  }
>  
> 


-- 
Nicolas Ferre