netdev - Re: [PATCH net 1/3] ipip: Properly mark ipip GRO packets as encapsulated.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1458253749.31963.4.camel@edumazet-glaptop3.roam.corp.google.com>
Date:	Thu, 17 Mar 2016 15:29:09 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Jesse Gross <jesse@...nel.org>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Patrick Boutilier <boutilpj@...et.ns.ca>
Subject: Re: [PATCH net 1/3] ipip: Properly mark ipip GRO packets as
 encapsulated.

On Thu, 2016-03-17 at 11:25 -0700, Jesse Gross wrote:
> ipip encapsulated packets can be merged together by GRO but the result
> does not have the proper GSO type set or even marked as being
> encapsulated at all. Later retransmission of these packets will likely
> fail if the device does not support ipip offloads. This is similar to
> the issue resolved in IPv6 sit in feec0cb3
> ("ipv6: gro: support sit protocol").
> 
> Reported-by: Patrick Boutilier <boutilpj@...et.ns.ca>
> Fixes: 9667e9bb ("ipip: Add gro callbacks to ipip offload")
> Signed-off-by: Jesse Gross <jesse@...nel.org>
> ---

Acked-by: Eric Dumazet <edumazet@...gle.com>