lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Mar 2016 12:10:37 +0000 From: Alexey Brodkin <Alexey.Brodkin@...opsys.com> To: "sergei.shtylyov@...entembedded.com" <sergei.shtylyov@...entembedded.com> CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Vineet.Gupta1@...opsys.com" <Vineet.Gupta1@...opsys.com>, "linux-snps-arc@...ts.infradead.org" <linux-snps-arc@...ts.infradead.org>, "stable@...r.kernel.org" <stable@...r.kernel.org>, "robh@...nel.org" <robh@...nel.org>, "preid@...ctromag.com.au" <preid@...ctromag.com.au>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "davem@...emloft.net" <davem@...emloft.net> Subject: Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts Hi Sergei, On Thu, 2016-03-17 at 14:59 +0300, Sergei Shtylyov wrote: > Hello. > > On 3/17/2016 2:41 PM, Vineet Gupta wrote: > > > > > > > > > > > > > > > > > > > > Following commit broke DW GMAC functionality on AXS10x boards: > > > > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461e > > > > > d763 > > > > Note that scripts/checkpatch.pl now enforces certain format for citing > > > > commits: commit <12-digit SHA1> ("<commit summary>"). > > > > > > > > Frankly I haven't run that patch through checkpatch due to patch > > > simplicity. > > > > > > But I'll try to not do any assumptions from now on and will try to > > > use checkpatch for each and every thing I send :) > > > > > > Thanks for spotting all his! > > > > Sorry for not reporting everything on the 1st review. > > > > > > > > > -Alexey > > Sergei, do you mind providing a Ack/Reviewed-by on the patch below > > > > Reviewed-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> > > The patch here is white space damaged however: tabs were converted to > spaces. :-( Well, I'm not really sure why that substitution happened because my local patch is indeed with tabs. That's an output of checkpatch: ------------------------>8------------------------ ./scripts/checkpatch.pl 0001-ARC-axs10x-add-Ethernet-PHY-description-in-.dts.patch [1]+ Done gedit 0001-ARC-axs10x-add-Ethernet-PHY-description-in-.dts.patch WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) #7: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763 ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit e34d65696d2e ("stmmac: create of compatible mdio bus for stmmac driver")' #7: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763 total: 1 errors, 1 warnings, 14 lines checked 0001-ARC-axs10x-add-Ethernet-PHY-description-in-.dts.patch has style problems, please review. ------------------------>8------------------------ If there were spaces we would see tons of: ------------------------>8------------------------ ERROR: code indent should use tabs where possible #43: FILE: arch/arc/boot/dts/axs10x_mb.dtsi:50: + mdio0 {$ ------------------------>8------------------------ which I didn't see. -Alexey
Powered by blists - more mailing lists