lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Mar 2016 15:50:32 +0100 From: Andrew Lunn <andrew@...n.ch> To: Vishal Thanki <vishalthanki@...il.com> Cc: ujhelyi.m@...il.com, f.fainelli@...il.com, netdev@...r.kernel.org Subject: Re: [PATCH] net: phy: at803x: Add support to control PHY LEDs On Thu, Mar 17, 2016 at 02:59:07PM +0100, Vishal Thanki wrote: > The LEDs can be turned on and off by a sysfs interface > now. Write 0 to "led_enable" file to turn off the LEDs > and write 1 to turn on. The support is experimental > and can be enabled by kernel configuration option. > > Signed-off-by: Vishal Thanki <vishalthanki@...il.com> > --- > drivers/net/phy/Kconfig | 7 +++++ > drivers/net/phy/at803x.c | 71 ++++++++++++++++++++++++++++++++++++++++++++++++ Hi Vishal This solution seems specific to the at803. You should be thinking of a generic solution that all PHYs can use. eg add a new callback function to phy_driver, and put the sysfs handling code in phylib. Andrew
Powered by blists - more mailing lists