netdev - Re: [PATCH net-next] cls_bpf: reset class and reuse major in da

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160318.193547.1427258902252761452.davem@davemloft.net>
Date:	Fri, 18 Mar 2016 19:35:47 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	daniel@...earbox.net
Cc:	alexei.starovoitov@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] cls_bpf: reset class and reuse major in da

From: Daniel Borkmann <daniel@...earbox.net>
Date: Tue, 15 Mar 2016 22:41:22 +0100

> There are two issues with the current code. First one is that we need
> to set res->class to 0 in case we use non-default classid matching.
> 
> This is important for the case where cls_bpf was initially set up with
> an optional binding to a default class with tcf_bind_filter(), where
> the underlying qdisc implements bind_tcf() that fills res->class and
> tests for it later on when doing the classification. Convention for
> these cases is that after tc_classify() was called, such qdiscs (atm,
> drr, qfq, cbq, hfsc, htb) first test class, and if 0, then they lookup
> based on classid.
> 
> Second, there's a bug with da mode, where res->classid is only assigned
> a 16 bit minor, but it needs to expand to the full 32 bit major/minor
> combination instead, therefore we need to expand with the bound major.
> This is fine as classes belonging to a classful qdisc must share the
> same major.
> 
> Fixes: 045efa82ff56 ("cls_bpf: introduce integrated actions")
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> Acked-by: Alexei Starovoitov <ast@...nel.org>

Applied, thanks Daniel.