netdev - Re: [patch] ethernet: micrel: fix some error codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160318.194047.1657460162512006177.davem@davemloft.net>
Date:	Fri, 18 Mar 2016 19:40:47 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dan.carpenter@...cle.com
Cc:	richard.rojfors@...agicore.com, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] ethernet: micrel: fix some error codes

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Wed, 16 Mar 2016 10:45:10 +0300

> There were two issues here:
> 1) dma_mapping_error() return true/false but we want to return -ENOMEM
> 2) If dmaengine_prep_slave_sg() failed then "err" wasn't set but
>    presumably that should be -ENOMEM as well.
> 
> I changed the success path to "return 0;" instead of "return ret;" for
> clarity.
> 
> Fixes: 94fe8c683cea ('ks8842: Support DMA when accessed via timberdale')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied.