netdev - Re: [PATCH net-next] virtio_net: replace netdev_alloc_skb_ip_align() with napi_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHdzE-_u35Kg1zck1KKCYhu5epx4vNtzE7UX41Bi85vsJ55ROw@mail.gmail.com>
Date:	Thu, 17 Mar 2016 18:01:23 -0700
From:	Venkatesh Srinivas <venkateshs@...gle.com>
To:	Paolo Abeni <pabeni@...hat.com>
Cc:	netdev@...r.kernel.org, virtualization@...ts.linux-foundation.org,
	Hannes Frederic Sowa <hannes@...essinduktion.org>,
	"Michael S. Tsirkin" <mst@...hat.com>
Subject: Re: [PATCH net-next] virtio_net: replace netdev_alloc_skb_ip_align()
 with napi_alloc_skb()

On Thu, Mar 17, 2016 at 7:44 AM, Paolo Abeni <pabeni@...hat.com> wrote:
>
> This gives small but noticeable rx performance improvement (2-3%)
> and will allow exploiting future napi improvement.
>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> ---

Worked in my tests, though the performance win was in the noise (+0.6%
- +1% bandwidth).
What tests did you see a 2-3% win on?

Do you think its worth modifying add_recvbuf_small() to use
napi_alloc_skb() when called from
Rx NAPI (virtnet_receive)?

Tested-by: Venkatesh Srinivas <venkateshs@...gle.com>

Thanks,
-- vs;