netdev - Re: [PATCH] change nfqueue fail-open mechanism to apply also to receive message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201603201651.4jjiMCel%fengguang.wu@intel.com>
Date:	Sun, 20 Mar 2016 16:16:30 +0800
From:	kbuild test robot <lkp@...el.com>
To:	"Yigal Reiss (yreiss)" <yreiss@...co.com>
Cc:	kbuild-all@...org,
	"'netdev@...r.kernel.org'" <netdev@...r.kernel.org>,
	"netfilter-devel@...r.kernel.org" <netfilter-devel@...r.kernel.org>,
	"Florian Westphal (fw@...len.de)" <fw@...len.de>
Subject: Re: [PATCH] change nfqueue fail-open mechanism to apply also to
 receive message

Hi Yigal,

[auto build test WARNING on v4.5-rc7]
[cannot apply to nf-next/master net-next/master next-20160318]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Yigal-Reiss-yreiss/change-nfqueue-fail-open-mechanism-to-apply-also-to-receive-message/20160320-160132
config: xtensa-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

All warnings (new ones prefixed by >>):

   net/netlink/af_netlink.c: In function 'netlink_unicast_nofree':
>> net/netlink/af_netlink.c:1876:2: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
     if (err = sk_filter(sk, skb)) {
     ^

vim +1876 net/netlink/af_netlink.c

  1860	{
  1861		struct sock *sk;
  1862		int err;
  1863		long timeo;
  1864	
  1865		skb = netlink_trim(skb, gfp_any());
  1866	
  1867		timeo = sock_sndtimeo(ssk, nonblock);
  1868	retry:
  1869		sk = netlink_getsockbyportid(ssk, portid);
  1870		if (IS_ERR(sk)) {
  1871			return PTR_ERR(sk);
  1872		}
  1873		if (netlink_is_kernel(sk))
  1874			return netlink_unicast_kernel(sk, skb, ssk);
  1875	
> 1876		if (err = sk_filter(sk, skb)) {
  1877			sock_put(sk);
  1878			return err;
  1879		}
  1880	
  1881		err = netlink_attachskb_nofree(sk, skb, &timeo, ssk);
  1882		if (err == 1)
  1883			goto retry;
  1884		if (err)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (44058 bytes)