netdev - Re: [PATCH] net: Add missing kernel-doc for netdev ptype lists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56F06BF9.6010004@osg.samsung.com>
Date:	Mon, 21 Mar 2016 21:47:37 +0000
From:	Luis de Bethencourt <luisbg@....samsung.com>
To:	Benjamin Poirier <bpoirier@...e.com>, netdev@...r.kernel.org
CC:	Salam Noureddine <noureddine@...sta.com>
Subject: Re: [PATCH] net: Add missing kernel-doc for netdev ptype lists

On 21/03/16 21:08, Benjamin Poirier wrote:
> .//include/linux/netdevice.h:1826: warning: No description found for parameter 'ptype_all'
> .//include/linux/netdevice.h:1826: warning: No description found for parameter 'ptype_specific'
> 
> Introduced by commit 7866a621043f ("dev: add per net_device packet type
> chains")
> 
> Cc: Salam Noureddine <noureddine@...sta.com>
> Signed-off-by: Benjamin Poirier <bpoirier@...e.com>
> ---
>  include/linux/netdevice.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 9a3d55c..1937bdd 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -1418,6 +1418,8 @@ enum netdev_priv_flags {
>   *	@unreg_list:	List entry, that is used, when we are unregistering the
>   *			device, see the function unregister_netdev
>   *	@close_list:	List entry, that is used, when we are closing the device
> + *	@ptype_all:     Device-specific packet handlers for all protocols
> + *	@ptype_specific: Device-specific, protocol-specific packet handlers
>   *
>   *	@adj_list:	Directly linked devices, like slaves for bonding
>   *	@all_adj_list:	All linked devices, *including* neighbours
> 

Looks good to me.

Thanks Benjamin :)

Luis