netdev - Re: [PATCH net 09/10] net: hns: adds limitation for debug port mtu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56F0028D.4070500@cogentembedded.com>
Date:	Mon, 21 Mar 2016 17:17:49 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Yisen Zhuang <Yisen.Zhuang@...wei.com>, davem@...emloft.net
Cc:	yankejian@...wei.com, huangdaode@...ilicon.com,
	salil.mehta@...wei.com, lisheng011@...wei.com,
	lipeng321@...wei.com, liguozhu@...wei.com, arnd@...db.de,
	xieqianqian@...wei.com, andrew@...n.ch, ivecera@...hat.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linuxarm@...wei.com
Subject: Re: [PATCH net 09/10] net: hns: adds limitation for debug port mtu

Hello.

On 03/21/2016 02:06 PM, Yisen Zhuang wrote:

> From: Kejian Yan <yankejian@...wei.com>
>
> If mtu for debug port is set more than 1500, it may cause that packets
> are dropped by ppe. So maximum value for debug port should be 1500.
>
> Signed-off-by: Kejian Yan <yankejian@...wei.com>
> Signed-off-by: Yisen Zhuang <Yisen.Zhuang@...wei.com>
[...]
> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h
> index a69c8af..a68efd6 100644
> --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h
> +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h
> @@ -28,6 +28,7 @@ struct dsaf_device;
>   #define MAC_MAX_MTU		9600
>   #define MAC_MAX_MTU_V2		9728
>   #define MAC_MIN_MTU		68
> +#define MAC_MAX_MTU_DBG         MAC_DEFAULT_MTU

    Please use tabs, not spaces to indent the value, like above

[...]

MBR, Sergei