netdev - Re: [PATCH net] vxlan: fix sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 21 Mar 2016 13:30:24 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jbenc@...hat.com
Cc:	netdev@...r.kernel.org, fengguang.wu@...el.com
Subject: Re: [PATCH net] vxlan: fix sparse warnings

From: Jiri Benc <jbenc@...hat.com>
Date: Mon, 21 Mar 2016 17:39:18 +0100

> Sparse reports false positives for the header manipulation inlines. Annotate
> them correctly.
> 
> Tested by sparse on a little endian and big endian machine.
> 
> Fixes: 54bfd872bf16d ("vxlan: keep flags and vni in network byte order")
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Signed-off-by: Jiri Benc <jbenc@...hat.com>

Applied, thanks Jiri.

> As a side note, I tried to simplify all of these functions by using nested
> be32_to_cpu(cpu_to_be32()) calls but GCC seems not to be clever enough to
> optimize the byteswaps out.

Ok, thanks for the note, thanks again.