netdev - Re: [patch iproute2 2/2] add devlink tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160321122040.0f0788ff@xeon-e3>
Date:	Mon, 21 Mar 2016 12:20:40 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, idosch@...lanox.com,
	eladr@...lanox.com, yotamg@...lanox.com, ogerlitz@...lanox.com,
	yishaih@...lanox.com, dledford@...hat.com, sean.hefty@...el.com,
	hal.rosenstock@...il.com, eugenia@...lanox.com,
	roopa@...ulusnetworks.com, nikolay@...ulusnetworks.com,
	hadarh@...lanox.com, jhs@...atatu.com, john.fastabend@...il.com,
	jeffrey.t.kirsher@...el.com, brouer@...hat.com, ivecera@...hat.com,
	rami.rosen@...el.com, hannes@...essinduktion.org,
	gospo@...ulusnetworks.com
Subject: Re: [patch iproute2 2/2] add devlink tool

On Tue, 15 Mar 2016 15:43:49 +0100
Jiri Pirko <jiri@...nulli.us> wrote:

> From: Jiri Pirko <jiri@...lanox.com>
> 
> Add new tool called devlink which is userspace counterpart of devlink
> Netlink socket.
> 
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Lots of checkpatch issues.


ERROR: code indent should use tabs where possible
#509: FILE: devlink/devlink.c:161:
+                return -1;$

WARNING: please, no spaces at the start of a line
#509: FILE: devlink/devlink.c:161:
+                return -1;$

ERROR: open brace '{' following function declarations go on the next line
#854: FILE: devlink/devlink.c:506:
+static void cmd_dev_help(void) {

WARNING: else is not generally useful after a break or return
#911: FILE: devlink/devlink.c:563:
+		return cmd_dev_show(dl);
+	} else {

ERROR: open brace '{' following function declarations go on the next line
#918: FILE: devlink/devlink.c:570:
+static void cmd_port_help(void) {

WARNING: line over 100 characters
#945: FILE: devlink/devlink.c:597:
+			uint16_t des_port_type = mnl_attr_get_u16(tb[DEVLINK_ATTR_PORT_DESIRED_TYPE]);

WARNING: else is not generally useful after a break or return
#1059: FILE: devlink/devlink.c:711:
+		return cmd_port_unsplit(dl);
+	} else {

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
#1108: FILE: devlink/devlink.c:760:
+	unsigned index = 0;

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
#1159: FILE: devlink/devlink.c:811:
+	unsigned index = 0;

ERROR: open brace '{' following function declarations go on the next line
#1179: FILE: devlink/devlink.c:831:
+static void cmd_mon_help(void) {

WARNING: else is not generally useful after a break or return
#1192: FILE: devlink/devlink.c:844:
+		return cmd_mon_show(dl);
+	} else {

ERROR: open brace '{' following function declarations go on the next line
#1199: FILE: devlink/devlink.c:851:
+static void help(void) {

WARNING: else is not generally useful after a break or return
#1219: FILE: devlink/devlink.c:871:
+		return cmd_mon(dl);
+	} else {

ERROR: space required before the open parenthesis '('
#1286: FILE: devlink/devlink.c:938:
+		switch(opt) {

ERROR: space required before the open parenthesis '('
#1426: FILE: devlink/mnlg.c:93:
+	switch(type) {

WARNING: 'splitted' may be misspelled - perhaps 'split'?
#1909: FILE: man/man8/devlink-port.8:79:
+.SS devlink port unsplit - unsplit previously splitted devlink port

WARNING: 'splitted' may be misspelled - perhaps 'split'?
#1910: FILE: man/man8/devlink-port.8:80:
+Could be performed on any splitted port of the same split group.

WARNING: 'splitted' may be misspelled - perhaps 'split'?
#1947: FILE: man/man8/devlink-port.8:117:
+Unplit the specified previously splitted devlink port.