netdev - Re: [PATCH] macb: fix PHY reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Mar 2016 22:34:05 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	netdev@...r.kernel.org, nicolas.ferre@...el.com
Subject: Re: [PATCH] macb: fix PHY reset

On 03/22/2016 10:27 PM, Sergei Shtylyov wrote:

> The driver calls gpiod_set_value() with GPIOD_OUT_* instead of 0 and 1, as
> a result the PHY isn't really  put back into reset state in macb_remove().
> Moreover, the driver assumes that something else has set the GPIO direction
> to output, so if  it has not, the PHY wouldn't be taken out of reset in

    s/wouldn't/may not/, sorry. Do I need to resend?

> macb_probe() either...
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

MBR, Sergei