lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <C4896FB061E7DE4AAC93031BDCA044B11A2146FF@IRSMSX108.ger.corp.intel.com> Date: Tue, 22 Mar 2016 13:02:02 +0000 From: "Varlese, Marco" <marco.varlese@...el.com> To: "netdev@...r.kernel.org" <netdev@...r.kernel.org> CC: "davem@...emloft.net" <davem@...emloft.net>, Jiri Pirko <jiri@...nulli.us>, John Fastabend <john.fastabend@...il.com>, "jhs@...atatu.com" <jhs@...atatu.com>, "Szczerbik, PrzemyslawX" <przemyslawx.szczerbik@...el.com> Subject: [PATCH iproute2 v1 1/1] lib/utils: fix get_addr() and get_prefix() error messages An attempt to add invalid address to interface would print "???" string instead of the address family name. For example: $ ip address add 256.10.166.1/24 dev ens8 Error: ??? prefix is expected rather than "256.10.166.1/24". $ ip neighbor add proxy 2001:db8::g dev ens8 Error: ??? address is expected rather than "2001:db8::g". With this patch the output will look like: $ ip address add 256.10.166.1/24 dev ens8 Error: inet prefix is expected rather than "256.10.166.1/24". $ ip neighbor add proxy 2001:db8::g dev ens8 Error: inet6 address is expected rather than "2001:db8::g". Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@...el.com> Signed-off-by: Marco Varlese <marco.varlese@...el.com> --- lib/utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/utils.c b/lib/utils.c index fa35f4d..4820de1 100644 --- a/lib/utils.c +++ b/lib/utils.c @@ -567,7 +567,7 @@ int get_addr(inet_prefix *dst, const char *arg, int family) { if (get_addr_1(dst, arg, family)) { fprintf(stderr, "Error: %s address is expected rather than \"%s\".\n", - family_name(family) ,arg); + family_name(dst->family), arg); exit(1); } return 0; @@ -581,7 +581,7 @@ int get_prefix(inet_prefix *dst, char *arg, int family) } if (get_prefix_1(dst, arg, family)) { fprintf(stderr, "Error: %s prefix is expected rather than \"%s\".\n", - family_name(family) ,arg); + family_name(dst->family), arg); exit(1); } return 0; -- 2.5.0
Powered by blists - more mailing lists