netdev - Re: [PATCH net] ppp: take reference on channels netns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160323160222.GB2231@uranus.lan>
Date:	Wed, 23 Mar 2016 19:02:22 +0300
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Guillaume Nault <g.nault@...halink.fr>
Cc:	netdev@...r.kernel.org, Baozeng Ding <sploving1@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH net] ppp: take reference on channels netns

On Wed, Mar 23, 2016 at 04:38:55PM +0100, Guillaume Nault wrote:
> Let channels hold a reference on their network namespace.
> Some channel types, like ppp_async and ppp_synctty, can have their
> userspace controller running in a different namespace. Therefore they
> can't rely on them to preclude their netns from being removed from
> under them.
> 
...
> 
> Fixes: 273ec51dd7ce ("net: ppp_generic - introduce net-namespace functionality v2")
> Reported-by: Baozeng Ding <sploving1@...il.com>
> Signed-off-by: Guillaume Nault <g.nault@...halink.fr>

Good catch! Thanks!

Reviewed-by: Cyrill Gorcunov <gorcunov@...nvz.org>