netdev - Re: [PATCH 3/3] led: at8030: Add LED driver for AT8030 ethernet PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160323185246.GM5250@lunn.ch>
Date:	Wed, 23 Mar 2016 19:52:46 +0100
From:	Andrew Lunn <andrew@...n.ch>
To:	Vishal Thanki <vishalthanki@...il.com>
Cc:	f.fainelli@...il.com, ujhelyi.m@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH 3/3] led: at8030: Add LED driver for AT8030 ethernet PHY

> +static void at803x_led_work(struct work_struct *work)
> +{
> +	struct at803x_phy_led *led =
> +		container_of(work, struct at803x_phy_led, work);
> +	union at803x_led_manual_ctrl regval = led->regval;
> +
> +	phy_write(led->led_grp->phydev, led->reg, regval.value);
> +}
> +

There has recently been a big refactoring of the LED code. You should
no longer need a work queue. The core will do that for you.

   Andrew