netdev - Re: [PATCH net 1/2] net: bcmgenet: fix dev->stats.tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B161205E-3917-42F9-9831-BA05F94FCCB9@gmail.com>
Date:	Wed, 23 Mar 2016 15:02:33 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Petri Gynther <pgynther@...gle.com>, netdev@...r.kernel.org
CC:	davem@...emloft.net, jaedon.shin@...il.com, edumazet@...gle.com
Subject: Re: [PATCH net 1/2] net: bcmgenet: fix dev->stats.tx_bytes accounting

On March 23, 2016 1:01:28 PM PDT, Petri Gynther <pgynther@...gle.com> wrote:
>1. Add bytes_compl local variable to collect transmitted bytes
>   - dev->stats updates can then be moved outside the while-loop
>   - bytes_compl is also needed for future BQL support
>2. When bcmgenet device uses Tx checksum offload, each transmitted
>   skb has an extra 64-byte header prepended to it. This needs to
>   be deducted when counting transmitted bytes.
>3. skb->len covers the entire length of skb, whether it is linear or
>   fragmented. Thus, when we clean the fragments, do not increase
>   transmitted bytes.
>
>Signed-off-by: Petri Gynther <pgynther@...gle.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>

Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file")

-- 
Florian