netdev - Re: [PATCH net v2 1/2] net: bcmgenet: fix dev->stats.tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160324.151519.1184406640007918441.davem@davemloft.net>
Date:	Thu, 24 Mar 2016 15:15:19 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	pgynther@...gle.com
Cc:	netdev@...r.kernel.org, f.fainelli@...il.com,
	jaedon.shin@...il.com, edumazet@...gle.com
Subject: Re: [PATCH net v2 1/2] net: bcmgenet: fix dev->stats.tx_bytes
 accounting

From: Petri Gynther <pgynther@...gle.com>
Date: Thu, 24 Mar 2016 11:27:20 -0700

> 1. Add bytes_compl local variable to __bcmgenet_tx_reclaim() to collect
>    transmitted bytes. dev->stats updates can then be moved outside the
>    while-loop. bytes_compl is also needed for future BQL support.
> 2. When bcmgenet device uses Tx checksum offload, each transmitted skb
>    gets an extra 64-byte header prepended to it. Before this header is
>    prepended to the skb, we need to save the skb "wire" length in
>    GENET_CB(skb)->bytes_sent, so that proper Tx bytes accounting can
>    be done in __bcmgenet_tx_reclaim().
> 3. skb->len covers the entire length of skb, whether it is linear or
>    fragmented. Thus, when we clean the fragments, do not increase
>    transmitted bytes.
> 
> Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file")
> Signed-off-by: Petri Gynther <pgynther@...gle.com>

Applied.