netdev - Re: [PATCH v2 1/1] net: macb: remove BUG_ON() and reset the queue to handle RX errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160325.114423.859412154606595295.davem@davemloft.net>
Date:	Fri, 25 Mar 2016 11:44:23 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	cyrille.pitchen@...el.com
Cc:	nicolas.ferre@...el.com, linux-arm-kernel@...ts.infradead.org,
	netdev@...r.kernel.org, soren.brinkmann@...inx.com,
	linux-kernel@...r.kernel.org, narmstrong@...libre.com
Subject: Re: [PATCH v2 1/1] net: macb: remove BUG_ON() and reset the queue
 to handle RX errors

From: Cyrille Pitchen <cyrille.pitchen@...el.com>
Date: Fri, 25 Mar 2016 10:37:34 +0100

> This patch removes two BUG_ON() used to notify about RX queue corruptions
> on macb (not gem) hardware without actually handling the error.
> 
> The new code skips corrupted frames but still processes faultless frames.
> Then it resets the RX queue before restarting the reception from a clean
> state.
> 
> This patch is a rework of an older patch proposed by Neil Armstrong:
> http://patchwork.ozlabs.org/patch/371525/
> 
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@...el.com>
> Acked-by: Neil Armstrong <narmstrong@...libre.com>
> Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>

Applied, thank you.