netdev - Re: [PATCH 1/2] net: dsa: mv88e6xxx: Introduce _mv88e6xxx_phy_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87lh55hvyb.fsf@ketchup.mtl.sfl>
Date:	Sat, 26 Mar 2016 15:37:32 -0400
From:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:	Andrew Lunn <andrew@...n.ch>
Cc:	Guenter Roeck <linux@...ck-us.net>,
	Patrick Uiterwijk <patrick@...terwijk.org>,
	davem@...emloft.net, linux@....linux.org.uk,
	netdev@...r.kernel.org, Dennis Gilmore <dennis@...il.us>,
	Peter Robinson <pbrobinson@...il.com>
Subject: Re: [PATCH 1/2] net: dsa: mv88e6xxx: Introduce _mv88e6xxx_phy_page_{read,write}

Hi Andrew,

Andrew Lunn <andrew@...n.ch> writes:

>> "error" definitely doesn't make sense, especially in case of success. If
>> one has a better suggestion that "clear" for the label, I don't really
>> mind.
>
> Hi Vivien, Guenter
>
> page_0 ?

For some unjustified reasons I prefered single word labels, but multiple
words will be cleared indeed.

page_0 is fine. What about an even more explicit "clear_page_0" label?

Thanks,
Vivien