lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <56F6F79C.2030102@roeck-us.net> Date: Sat, 26 Mar 2016 13:57:00 -0700 From: Guenter Roeck <linux@...ck-us.net> To: Vivien Didelot <vivien.didelot@...oirfairelinux.com>, Patrick Uiterwijk <patrick@...terwijk.org> Cc: davem@...emloft.net, linux@....linux.org.uk, andrew@...n.ch, netdev@...r.kernel.org, Dennis Gilmore <dennis@...il.us>, Peter Robinson <pbrobinson@...il.com> Subject: Re: [PATCH 1/2] net: dsa: mv88e6xxx: Introduce _mv88e6xxx_phy_page_{read,write} On 03/26/2016 11:32 AM, Vivien Didelot wrote: > Hi Guenter, > > Guenter Roeck <linux@...ck-us.net> writes: > >>>> Is there some good reason for changing the name of those labels ? >>> >>> Vivien suggested to rename this since it makes more clear that this write is >>> meant to return to page 0 to make sure that phylib doesn't get confused >>> about the currently active page. >>> >> >> And "clear:" accomplishes that ? I would not have guessed. >> Wonder if anyone else does. I would have used a comment. >> /* Try to return to page 0 even after an error */ >> or something like that. > > "error" definitely doesn't make sense, especially in case of success. If > one has a better suggestion that "clear" for the label, I don't really > mind. Sounds like POV to me. I don't like changing label names, because someone else may come the next day and change it again. At the end, one ends up in a label name war. It also makes patches look more complicated than necessary, and it _is_ an unrelated change. I don't understand the problem with adding a comment, and using a label name in place of a comment seems odd to me. Anyway, this has all become philosophical, meaning I'll stay out of it. Pick whatever you want ... Cheers, Guenter
Powered by blists - more mailing lists