netdev - Re: [PATCH] ravb: fix software timestamping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56F7D713.3060208@cogentembedded.com>
Date:	Sun, 27 Mar 2016 15:50:27 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Lino Sanfilippo <LinoSanfilippo@....de>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ravb: fix software timestamping

Hello.

On 03/27/2016 01:22 PM, Lino Sanfilippo wrote:

> In ravb_start_xmit dont call skb_tx_timestamp only when hardware
> timestamping is requested: in the latter case software timestamps are
> suppressed and thus the call of skb_tx_timestamp does not have any effect.
>
> Instead call skb_tx_timestamp unconditionally in ravb_start_xmit, since
> the function checks itself if software timestamping is required or should
> be skipped due to hardware timestamping.
>
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@....de>

Acked-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

MBR, Sergei