netdev - Re: [PATCH] iwlwifi: pcie: remove duplicate assignment of variable isr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1459165154.9638.3.camel@intel.com>
Date:	Mon, 28 Mar 2016 11:39:14 +0000
From:	"Grumbach, Emmanuel" <emmanuel.grumbach@...el.com>
To:	linuxwifi <linuxwifi@...el.com>,
	"colin.king@...onical.com" <colin.king@...onical.com>,
	"kvalo@...eaurora.org" <kvalo@...eaurora.org>,
	"Sharon, Sara" <sara.sharon@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Berg, Johannes" <johannes.berg@...el.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iwlwifi: pcie: remove duplicate assignment of variable
 isr_stats

On Mon, 2016-03-28 at 12:33 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> isr_stats is written twice with the same value, remove one of the
> redundant assignments to isr_stats.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---


Applied - thanks.

>  drivers/net/wireless/intel/iwlwifi/pcie/rx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
> b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
> index 4be3c35..253e4f0 100644
> --- a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
> @@ -1805,7 +1805,7 @@ irqreturn_t iwl_pcie_irq_msix_handler(int irq,
> void *dev_id)
>  	struct msix_entry *entry = dev_id;
>  	struct iwl_trans_pcie *trans_pcie =
> iwl_pcie_get_trans_pcie(entry);
>  	struct iwl_trans *trans = trans_pcie->trans;
> -	struct isr_statistics *isr_stats = isr_stats = &trans_pcie
> ->isr_stats;
> +	struct isr_statistics *isr_stats = &trans_pcie->isr_stats;
>  	u32 inta_fh, inta_hw;
>  
>  	lock_map_acquire(&trans->sync_cmd_lockdep_map);