netdev - Re: [PATCH v8 net-next] ravb: Add dma queue interrupt support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 28 Mar 2016 23:32:16 +0900
From:	Yoshihiro Kaneko <ykaneko0929@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Simon Horman <horms@...ge.net.au>,
	Magnus Damm <magnus.damm@...il.com>,
	linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v8 net-next] ravb: Add dma queue interrupt support

Hello.

2016-03-27 22:02 GMT+09:00 Sergei Shtylyov <sergei.shtylyov@...entembedded.com>:
> Hello.
>
>
> On 03/22/2016 06:22 PM, Yoshihiro Kaneko wrote:
>
>> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@...esas.com>
>>
>> This patch supports the following interrupts.
>>
>> - One interrupt for multiple (timestamp, error, gPTP)
>> - One interrupt for emac
>> - Four interrupts for dma queue (best effort rx/tx, network control rx/tx)
>>
>> This patch improve efficiency of the interrupt handler by adding the
>> interrupt handler corresponding to each interrupt source described
>> above. Additionally, it reduces the number of times of the access to
>> EthernetAVB IF.
>> Also this patch prevent this driver depends on the whim of a boot loader.
>>
>> [ykaneko0929@...il.com: define bit names of registers]
>> [ykaneko0929@...il.com: add comment for gen3 only registers]
>> [ykaneko0929@...il.com: fix coding style]
>> [ykaneko0929@...il.com: update changelog]
>> [ykaneko0929@...il.com: gen3: fix initialization of interrupts]
>> [ykaneko0929@...il.com: gen3: fix clearing interrupts]
>> [ykaneko0929@...il.com: gen3: add helper function for request_irq()]
>> [ykaneko0929@...il.com: gen3: remove IRQF_SHARED flag for request_irq()]
>> [ykaneko0929@...il.com: revert ravb_close() and ravb_ptp_stop()]
>> [ykaneko0929@...il.com: avoid calling free_irq() to non-hooked interrupts]
>> [ykaneko0929@...il.com: make NC/BE interrupt handler a function]
>> [ykaneko0929@...il.com: make timestamp interrupt handler a function]
>> [ykaneko0929@...il.com: timestamp interrupt is handled in multiple
>>   interrupt handler instead of dma queue interrupt handler]
>> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@...esas.com>
>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@...il.com>
>
> [...]
>
> Acked-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

Many thanks for your review and much help!

>
> MBR, Sergei
>

Thanks,
kaneko