netdev - Re: [PATCH 0/3] Control ethernet PHY LEDs via LED subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Mar 2016 08:43:35 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Vishal Thanki <vishalthanki@...il.com>
Cc:	andrew@...n.ch, f.fainelli@...il.com, ujhelyi.m@...il.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH 0/3] Control ethernet PHY LEDs via LED subsystem

On Wed, 23 Mar 2016 18:51:37 +0100
Vishal Thanki <vishalthanki@...il.com> wrote:

> Hi all,
> 
> Based on suggestions from Andrew and Florian, I have made some changes
> to expose the ethernet PHY LEDs using kernel LED subsystem. The following
> ALPHA patchset introduces two new LED triggers:
> 
> 1) <phydev>-eth-phy-link:
> To monitor the PHY Link status
> 
> 2) <phydev>-eth-phy-activity:
> To monitor the PHY activity status. This trigger may still some more work
> because as of now it just takes decision to set the trigger based on
> PHY state machine and triggers the blink_set with delay_on and delay_off
> parameters set to 0.
> 
> Please provide the review comments so that I can work on this patchset to
> make it complete.
> 
> Thanks,
> Vishal
> 
> Vishal Thanki (3):
>   net: phy: Add ethernet PHY LED triggers
>   net: phy: at8030: Expose the Link and Activity LEDs
>   led: at8030: Add LED driver for AT8030 ethernet PHY
> 
>  drivers/leds/Kconfig         |   7 ++
>  drivers/leds/Makefile        |   1 +
>  drivers/leds/leds-at803x.c   | 158 +++++++++++++++++++++++++++++++++++++++++++
>  drivers/net/phy/Kconfig      |   7 ++
>  drivers/net/phy/Makefile     |   1 +
>  drivers/net/phy/at803x.c     |  55 ++++++++++++++-
>  drivers/net/phy/phy.c        |  20 +++++-
>  drivers/net/phy/phy_device.c |   4 ++
>  drivers/net/phy/phy_led.c    |  70 +++++++++++++++++++
>  drivers/net/phy/phy_led.h    |  37 ++++++++++
>  include/linux/leds.h         |   1 +
>  include/linux/phy.h          |   6 ++
>  include/linux/phy/at803x.h   |  45 ++++++++++++
>  13 files changed, 409 insertions(+), 3 deletions(-)
>  create mode 100644 drivers/leds/leds-at803x.c
>  create mode 100644 drivers/net/phy/phy_led.c
>  create mode 100644 drivers/net/phy/phy_led.h
>  create mode 100644 include/linux/phy/at803x.h
> 

There already is LED control via ethtool.
It is more important that the existing API (ethtool) still work.