netdev - Re: [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87vb45brxc.fsf@kamboji.qca.qualcomm.com>
Date:	Tue, 29 Mar 2016 11:37:51 +0300
From:	Kalle Valo <kvalo@...eaurora.org>
To:	Wei-Ning Huang <wnhuang@...omium.org>
Cc:	linux-wireless@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Amitkumar Karwar <akarwar@...vell.com>,
	Nishant Sarmukadam <nishants@...vell.com>, snanda@...gle.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call

Wei-Ning Huang <wnhuang@...omium.org> writes:

> "single skb allocation failure" happens when system is under heavy
> memory pressure.  Add __GFP_REPEAT to skb allocation call so kernel
> attempts to reclaim pages and retry the allocation.
>
> Signed-off-by: Wei-Ning Huang <wnhuang@...omium.org>

Is this really a proper way to fix the issue? This is the first time I'm
hearing about the flag and there isn't even a single user in
drivers/net. I would like to get confirmation from others that
__GFP_REPEAT is really ok to use in a wireless driver before I can take
this.

-- 
Kalle Valo