netdev - Re: [PATCH iproute2 v1 1/1] lib/utils: fix get_addr() and get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160330165420.36f98115@xeon-e3>
Date:	Wed, 30 Mar 2016 16:54:20 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	"Varlese, Marco" <marco.varlese@...el.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	Jiri Pirko <jiri@...nulli.us>,
	John Fastabend <john.fastabend@...il.com>,
	"jhs@...atatu.com" <jhs@...atatu.com>,
	"Szczerbik, PrzemyslawX" <przemyslawx.szczerbik@...el.com>
Subject: Re: [PATCH iproute2 v1 1/1] lib/utils: fix get_addr() and
 get_prefix() error messages

On Tue, 22 Mar 2016 13:02:02 +0000
"Varlese, Marco" <marco.varlese@...el.com> wrote:

> An attempt to add invalid address to interface would print "???" string
> instead of the address family name.
> 
> For example:
> $ ip address add 256.10.166.1/24 dev ens8
> Error: ??? prefix is expected rather than "256.10.166.1/24".
> 
> $ ip neighbor add proxy 2001:db8::g dev ens8
> Error: ??? address is expected rather than "2001:db8::g".
> 
> With this patch the output will look like:
> $ ip address add 256.10.166.1/24 dev ens8
> Error: inet prefix is expected rather than "256.10.166.1/24".
> 
> $ ip neighbor add proxy 2001:db8::g dev ens8
> Error: inet6 address is expected rather than "2001:db8::g".
> 
> Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@...el.com>
> Signed-off-by: Marco Varlese <marco.varlese@...el.com>
> ---
> lib/utils.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

If you look at git, I already applied this by manual fix.