netdev - Re: [PATCH net-next v3 2/2] net: dsa: mv88e6xxx: Clear the PDOWN bit on setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8737r8cazd.fsf@ketchup.mtl.sfl>
Date:	Wed, 30 Mar 2016 10:10:46 -0400
From:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:	Patrick Uiterwijk <patrick@...terwijk.org>, linux@...ck-us.net,
	davem@...emloft.net, andrew@...n.ch
Cc:	netdev@...r.kernel.org, dennis@...il.us, pbrobinson@...il.com,
	Patrick Uiterwijk <patrick@...terwijk.org>,
	Kevin Smith <kevin.smith@...csyscorp.com>,
	Lucile Quirion <lucile.quirion@...oirfairelinux.com>
Subject: Re: [PATCH net-next v3 2/2] net: dsa: mv88e6xxx: Clear the PDOWN bit on setup

Patrick Uiterwijk <patrick@...terwijk.org> writes:

> Some of the vendor-specific bootloaders set up this part
> of the initialization for us, so this was never added.
> However, since upstream bootloaders don't initialize the
> chip specifically, they leave the fiber MII's PDOWN flag
> set, which means that the CPU port doesn't connect.
>
> This patch checks whether this flag has been clear prior
> by something else, and if not make us clear it.
>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Patrick Uiterwijk <patrick@...terwijk.org>

Tested-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>

This fixes the SerDes link on my single 6352 x86 platform.

Thanks!
Vivien