netdev - Re: [net PATCH v2] gro: Allow tunnel stacking in the case of FOU/GUE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160330.160320.1141897932138398381.davem@davemloft.net>
Date:	Wed, 30 Mar 2016 16:03:20 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	aduyck@...antis.com
Cc:	jesse@...nel.org, netdev@...r.kernel.org,
	alexander.duyck@...il.com, tom@...bertland.com
Subject: Re: [net PATCH v2] gro: Allow tunnel stacking in the case of
 FOU/GUE

From: Alexander Duyck <aduyck@...antis.com>
Date: Tue, 29 Mar 2016 14:55:22 -0700

> This patch should fix the issues seen with a recent fix to prevent
> tunnel-in-tunnel frames from being generated with GRO.  The fix itself is
> correct for now as long as we do not add any devices that support
> NETIF_F_GSO_GRE_CSUM.  When such a device is added it could have the
> potential to mess things up due to the fact that the outer transport header
> points to the outer UDP header and not the GRE header as would be expected.
> 
> Fixes: fac8e0f579695 ("tunnels: Don't apply GRO to multiple layers of encapsulation.")
> Signed-off-by: Alexander Duyck <aduyck@...antis.com>
> ---
> 
> v2: Dropped switch statements per suggestion of Tom Herbert.

Applied, thanks Alex.