netdev - Re: [PATCH 3/4] net: w5100: enable to support sleepable register access interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160331.153040.1786802199114216613.davem@davemloft.net>
Date:	Thu, 31 Mar 2016 15:30:40 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	akinobu.mita@...il.com
Cc:	netdev@...r.kernel.org, msink@...monline.ru
Subject: Re: [PATCH 3/4] net: w5100: enable to support sleepable register
 access interface

From: Akinobu Mita <akinobu.mita@...il.com>
Date: Thu, 31 Mar 2016 01:38:39 +0900

> +	struct sk_buff_head tx_queue;

The way the queueing works in this driver is that it is only possible
to have one SKB being transmitted at one time.

This is evident by how the driver immediately stops the TX queue when
it is given a new packet to transmit, and this is woken up by the TX
completion IRQ.

So don't use a queue here, just use a plain single pointer.

The SKB queue you're using here is going to also do locking which is
even more unnecessary overhead.

Thanks.