netdev - Re: [PATCH] fec: Do not access unexisting register in Coldfire

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160331.164635.2025583994422727303.davem@davemloft.net>
Date:	Thu, 31 Mar 2016 16:46:35 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	festevam@...il.com
Cc:	fugang.duan@....com, troy.kisky@...ndarydevices.com,
	gerg@...inux.org, netdev@...r.kernel.org, fabio.estevam@....com
Subject: Re: [PATCH] fec: Do not access unexisting register in Coldfire

From: Fabio Estevam <festevam@...il.com>
Date: Thu, 31 Mar 2016 12:05:17 -0300

> From: Fabio Estevam <fabio.estevam@....com>
> 
> Commit 55cd48c821de ("net: fec: stop the "rcv is not +last, " error
> messages") introduces a write to a register that does not exist in
> Coldfire.
> 
> Move the FEC_FTRL register access inside the FEC_QUIRK_HAS_RACC 'if' block,
> so that we guarantee it will not be used on Coldfire CPUs.
> 
> Reported-by: Greg Ungerer <gerg@...inux.org>
> Signed-off-by: Fabio Estevam <fabio.estevam@....com>

Applied, thanks.