netdev - Re: [PATCH net-next 7/8] sock: enable timestamping using control messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-LP93PHb=fr3UCFtZhcSehsoO=oYvk09JhRTwXutfT25w@mail.gmail.com>
Date:	Wed, 30 Mar 2016 23:39:09 -0400
From:	Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:	Soheil Hassas Yeganeh <soheil.kdev@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Network Development <netdev@...r.kernel.org>,
	Willem de Bruijn <willemb@...gle.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Yuchung Cheng <ycheng@...gle.com>,
	Neal Cardwell <ncardwell@...gle.com>,
	Martin KaFai Lau <kafai@...com>,
	Soheil Hassas Yeganeh <soheil@...gle.com>
Subject: Re: [PATCH net-next 7/8] sock: enable timestamping using control messages

On Wed, Mar 30, 2016 at 6:37 PM, Soheil Hassas Yeganeh
<soheil.kdev@...il.com> wrote:
> From: Soheil Hassas Yeganeh <soheil@...gle.com>
>
> Currently, SOL_TIMESTAMPING can only be enabled using setsockopt.
> This is very costly when users want to sample writes to gather
> tx timestamps.
>
> Add support for enabling SO_TIMESTAMPING via control messages by
> using tsflags added in `struct sockcm_cookie` (added in the previous
> patches in this series) to set the tx_flags of the last skb created in
> a sendmsg. With this patch, the timestamp recording bits in tx_flags
> of the skbuff is overridden if SO_TIMESTAMPING is passed in a cmsg.
>
> Please note that this is only effective for overriding the recording
> timestamps flags. Users should enable timestamp reporting (e.g.,
> SOF_TIMESTAMPING_SOFTWARE | SOF_TIMESTAMPING_OPT_ID) using
> socket options and then should ask for SOF_TIMESTAMPING_TX_*
> using control messages per sendmsg to sample timestamps for each
> write.
>
> Signed-off-by: Soheil Hassas Yeganeh <soheil@...gle.com>

Acked-by: Willem de Bruijn <willemb@...gle.com>