netdev - Re: [PATCH] rds: rds-stress show all zeros after few minutes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160331142047.GA24193@shamir-linux.uk.oracle.com>
Date:	Thu, 31 Mar 2016 17:20:48 +0300
From:	Shamir Rabinovitch <shamir.rabinovitch@...cle.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	rds-devel@....oracle.com, netdev@...r.kernel.org,
	davem@...emloft.net
Subject: Re: [PATCH] rds: rds-stress show all zeros after few minutes

On Thu, Mar 31, 2016 at 04:13:35PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 3/31/2016 3:50 AM, shamir rabinovitch wrote:
> 
> >Issue can be seen on platforms that use 8K and above page size
> >while rds fragment size is 4K. On those platforms single page is
> >shared between 2 or more rds fragments. Each fragment has it's own
> 
>    Its.

Fixed in next version. 
Thanks.

> 
> >offeset and rds cong map code need to take this offset to account.
> 
>    Offset. What is "cong", congestion?

'Offset' is in middle of the sentence so it is OK as-is. 
Cong is short hand of congestion.
It will be replaces 
with the full word in next version.

> 
> >Not taking this offset to account lead to reading the data fragment
> >as congestion map fragment and hang of the rds transmit due to far
> >cong map corruption.
> >
> >Reviewed-by: Wengang Wang <wen.gang.wang@...cle.com>
> >Reviewed-by: Ajaykumar Hotchandani <ajaykumar.hotchandani@...cle.com>
> >Acked-by: Santosh Shilimkar <santosh.shilimkar@...cle.com>
> >Tested-by: Anand Bibhuti <anand.bibhuti@...cle.com>
> 
>    These should be after your sign-off, not before.

Thanks for the comment.
Will be fixed in next version.

> 
> >Signed-off-by: shamir rabinovitch <shamir.rabinovitch@...cle.com>
> [...]
> 
> MBR, Sergei
> 

Thanks for the review.
BR, Shamir