netdev - Re: [PATCH net-next v3 2/2] net: dsa: mv88e6xxx: Clear the PDOWN bit on setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160331.151326.1811698418230235797.davem@davemloft.net>
Date:	Thu, 31 Mar 2016 15:13:26 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	patrick@...terwijk.org
Cc:	linux@...ck-us.net, vivien.didelot@...oirfairelinux.com,
	andrew@...n.ch, netdev@...r.kernel.org, dennis@...il.us,
	pbrobinson@...il.com
Subject: Re: [PATCH net-next v3 2/2] net: dsa: mv88e6xxx: Clear the PDOWN
 bit on setup

From: Patrick Uiterwijk <patrick@...terwijk.org>
Date: Wed, 30 Mar 2016 01:39:41 +0000

> Some of the vendor-specific bootloaders set up this part
> of the initialization for us, so this was never added.
> However, since upstream bootloaders don't initialize the
> chip specifically, they leave the fiber MII's PDOWN flag
> set, which means that the CPU port doesn't connect.
> 
> This patch checks whether this flag has been clear prior
> by something else, and if not make us clear it.
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Patrick Uiterwijk <patrick@...terwijk.org>

Applied, thank you.