netdev - Re: [PATCH] bridge: remove br_dev_set_multicast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 01 Apr 2016 14:43:19 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	roy.qing.li@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] bridge: remove br_dev_set_multicast_list

From: roy.qing.li@...il.com
Date: Fri,  1 Apr 2016 16:16:10 +0800

> From: Li RongQing <roy.qing.li@...il.com>
> 
> remove br_dev_set_multicast_list which does nothing
> 
> Signed-off-by: Li RongQing <roy.qing.li@...il.com>

This will break SIOCADDMULTI et al. on the bridge, see net/core/dev.c
which checks whether this ndo OP is NULL or not.

Please sufficiently grep the source tree on how an ndo operation is
used before making changes like this.

Thanks.